Fix Detect Magic to have one debuff per caster. #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apply custom flags in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR fixes Detect Magic to have one debuff per caster.
Currently only one debuff is applied, no matter how many casters apply Detect Magic. It should be possible to apply multiple Detect Magic on a target. One for every mage.
I used SPELL_CUSTOM_SEPARATE_AURA_PER_CASTER to fix the spell, as there are no alternatives from what I've seen.
Image from vmangos with this PR applied:
Proof
https://youtu.be/9IMfIkC0dxg?t=40
Video from vanilla with Shazzrah having 3 Detect Magic debuffs on him
https://youtu.be/xchHtS9AG38?t=3m3s
Video from vanilla with Shazzrah having 2 Detect Magic debuffs on him
https://youtu.be/HWx1o7ECjI8?t=18m38s
Video from vanilla with a Rogue having 2 Detect Magic debuffs on him
Image from classic with two mages applying detect magic on a mob:
Issues
How2Test
Todo / Checklist